Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e91838b authored by Guenter Roeck's avatar Guenter Roeck Committed by Wim Van Sebroeck
Browse files

watchdog: core: Fix devres_alloc() allocation size 



Coverity reports:

Passing argument 152UL /* sizeof (*wdd) */ to function __devres_alloc_node
and then casting the return value to struct watchdog_device ** is
suspicious.

Allocation size needs to be sizeof(*rcwdd), not sizeof(*wdd).

Fixes: 83fbae5a ("watchdog: Add a device managed API for ...")
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 3be79886

drivers/watchdog/watchdog_core.c

+1 −1
Original line number Diff line number Diff line
@@ -349,7 +349,7 @@ int devm_watchdog_register_device(struct device *dev, 
	struct watchdog_device **rcwdd;

	int ret;



	rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*wdd),

	rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*rcwdd),

			     GFP_KERNEL);

	if (!rcwdd)

		return -ENOMEM;