Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e062856 authored by Baoyou Xie's avatar Baoyou Xie Committed by Alex Williamson
Browse files

vfio: platform: mark symbols static where possible 



We get a few warnings when building kernel with W=1:
drivers/vfio/platform/vfio_platform_common.c:76:5: warning: no previous prototype for 'vfio_platform_acpi_call_reset' [-Wmissing-prototypes]
drivers/vfio/platform/vfio_platform_common.c:98:6: warning: no previous prototype for 'vfio_platform_acpi_has_reset' [-Wmissing-prototypes]
drivers/vfio/platform/vfio_platform_common.c:640:5: warning: no previous prototype for 'vfio_platform_of_probe' [-Wmissing-prototypes]
drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:59:5: warning: no previous prototype for 'vfio_platform_amdxgbe_reset' [-Wmissing-prototypes]
drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c:60:5: warning: no previous prototype for 'vfio_platform_calxedaxgmac_reset' [-Wmissing-prototypes]
....

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.

Signed-off-by: default avatarBaoyou Xie <baoyou.xie@linaro.org>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarEric Auger <eric.auger@redhat.com>
Reviewed-by: default avatarBaptiste Reynal <b.reynal@virtualopensystems.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 8138dabb

drivers/vfio/platform/reset/vfio_platform_amdxgbe.c

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ static void xmdio_write(void *ioaddr, unsigned int mmd, 
	iowrite32(value, ioaddr + ((mmd_address & 0xff) << 2));

}



int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)

static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)

{

	struct vfio_platform_region *xgmac_regs = &vdev->regions[0];

	struct vfio_platform_region *xpcs_regs = &vdev->regions[1];

drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c

+1 −1
Original line number Diff line number Diff line
@@ -57,7 +57,7 @@ static inline void xgmac_mac_disable(void __iomem *ioaddr) 
	writel(value, ioaddr + XGMAC_CONTROL);

}



int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev)

static int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev)

{

	struct vfio_platform_region *reg = &vdev->regions[0];

drivers/vfio/platform/vfio_platform_common.c

+3 −3
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ static int vfio_platform_acpi_probe(struct vfio_platform_device *vdev, 
	return WARN_ON(!vdev->acpihid) ? -EINVAL : 0;

}



int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,

static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,

				  const char **extra_dbg)

{

#ifdef CONFIG_ACPI
@@ -95,7 +95,7 @@ int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, 
#endif

}



bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)

static bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)

{

#ifdef CONFIG_ACPI

	struct device *dev = vdev->device;
@@ -637,7 +637,7 @@ static const struct vfio_device_ops vfio_platform_ops = { 
	.mmap		= vfio_platform_mmap,

};



int vfio_platform_of_probe(struct vfio_platform_device *vdev,

static int vfio_platform_of_probe(struct vfio_platform_device *vdev,

			   struct device *dev)

{

	int ret;