Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d4dc890 authored by Ilya Loginov's avatar Ilya Loginov Committed by Jens Axboe
Browse files

block: add helpers to run flush_dcache_page() against a bio and a request's pages 



Mtdblock driver doesn't call flush_dcache_page for pages in request.  So,
this causes problems on architectures where the icache doesn't fill from
the dcache or with dcache aliases.  The patch fixes this.

The ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE symbol was introduced to avoid
pointless empty cache-thrashing loops on architectures for which
flush_dcache_page() is a no-op.  Every architecture was provided with this
flush pages on architectires where ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE is
equal 1 or do nothing otherwise.

See "fix mtd_blkdevs problem with caches on some architectures" discussion
on LKML for more information.

Signed-off-by: default avatarIlya Loginov <isloginov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Peter Horton <phorton@bitbox.co.uk>
Cc: "Ed L. Cashin" <ecashin@coraid.com>
Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent 3586e917

arch/alpha/include/asm/cacheflush.h

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
#define flush_cache_dup_mm(mm)			do { } while (0)

#define flush_cache_range(vma, start, end)	do { } while (0)

#define flush_cache_page(vma, vmaddr, pfn)	do { } while (0)

#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0

#define flush_dcache_page(page)			do { } while (0)

#define flush_dcache_mmap_lock(mapping)		do { } while (0)

#define flush_dcache_mmap_unlock(mapping)	do { } while (0)

arch/arm/include/asm/cacheflush.h

+1 −0
Original line number Diff line number Diff line
@@ -408,6 +408,7 @@ extern void flush_ptrace_access(struct vm_area_struct *vma, struct page *page, 
 * about to change to user space.  This is the same method as used on SPARC64.

 * See update_mmu_cache for the user space part.

 */

#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1

extern void flush_dcache_page(struct page *);



extern void __flush_dcache_page(struct address_space *mapping, struct page *page);

arch/avr32/include/asm/cacheflush.h

+1 −0
Original line number Diff line number Diff line
@@ -107,6 +107,7 @@ extern void flush_icache_page(struct vm_area_struct *vma, struct page *page); 
 * do something here, but only for certain configurations.  No such

 * configurations exist at this time.

 */

#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0

#define flush_dcache_page(page)			do { } while (0)

#define flush_dcache_mmap_lock(page)		do { } while (0)

#define flush_dcache_mmap_unlock(page)		do { } while (0)

arch/blackfin/include/asm/cacheflush.h

+2 −0
Original line number Diff line number Diff line
@@ -68,9 +68,11 @@ do { memcpy(dst, src, len); \ 
#endif

#if defined(CONFIG_BFIN_EXTMEM_WRITEBACK) || defined(CONFIG_BFIN_L2_WRITEBACK)

# define flush_dcache_range(start,end)		blackfin_dcache_flush_range((start), (end))

#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1

# define flush_dcache_page(page)		blackfin_dflush_page(page_address(page))

#else

# define flush_dcache_range(start,end)		do { } while (0)

#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0

# define flush_dcache_page(page)		do { } while (0)

#endif

arch/cris/include/asm/cacheflush.h

+1 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
#define flush_cache_dup_mm(mm)			do { } while (0)

#define flush_cache_range(vma, start, end)	do { } while (0)

#define flush_cache_page(vma, vmaddr, pfn)	do { } while (0)

#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0

#define flush_dcache_page(page)			do { } while (0)

#define flush_dcache_mmap_lock(mapping)		do { } while (0)

#define flush_dcache_mmap_unlock(mapping)	do { } while (0)