Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b18ab36 authored by Arnd Bergmann's avatar Arnd Bergmann
Browse files

net/wireless: use generic_file_llseek in debugfs 



The default llseek operation is changing from
default_llseek to no_llseek, so all code relying on
the current behaviour needs to make that explicit.

The wireless driver infrastructure and some of the drivers
make use of generated debugfs files, so they cannot
be converted by our script that automatically determines
the right operation.

All these files use debugfs and they typically rely
on simple_read_from_buffer, so the best llseek operation
here is generic_file_llseek.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
parent dc880abe

drivers/misc/iwmc3200top/debugfs.c

+3 −0
Original line number Diff line number Diff line
@@ -71,6 +71,7 @@ ssize_t iwmct_dbgfs_##name##_write(struct file *file, \ 
	static const struct file_operations iwmct_dbgfs_##name##_ops = {  \

		.read = iwmct_dbgfs_##name##_read,			\

		.open = iwmct_dbgfs_open_file_generic,			\

		.llseek = generic_file_llseek,				\

	};



#define DEBUGFS_WRITE_FILE_OPS(name)					\
@@ -78,6 +79,7 @@ ssize_t iwmct_dbgfs_##name##_write(struct file *file, \ 
	static const struct file_operations iwmct_dbgfs_##name##_ops = {  \

		.write = iwmct_dbgfs_##name##_write,			\

		.open = iwmct_dbgfs_open_file_generic,			\

		.llseek = generic_file_llseek,				\

	};



#define DEBUGFS_READ_WRITE_FILE_OPS(name)				\
@@ -87,6 +89,7 @@ ssize_t iwmct_dbgfs_##name##_write(struct file *file, \ 
		.write = iwmct_dbgfs_##name##_write,			\

		.read = iwmct_dbgfs_##name##_read,			\

		.open = iwmct_dbgfs_open_file_generic,			\

		.llseek = generic_file_llseek,				\

	};

drivers/net/wireless/b43/debugfs.c

+1 −0
Original line number Diff line number Diff line
@@ -627,6 +627,7 @@ static ssize_t b43_debugfs_write(struct file *file, 
			.open	= b43_debugfs_open,		\

			.read	= b43_debugfs_read,		\

			.write	= b43_debugfs_write,		\

			.llseek = generic_file_llseek,		\

		},						\

		.file_struct_offset = offsetof(struct b43_dfsentry, \

					       file_##name),	\

drivers/net/wireless/b43legacy/debugfs.c

+1 −0
Original line number Diff line number Diff line
@@ -334,6 +334,7 @@ static ssize_t b43legacy_debugfs_write(struct file *file, 
			.open	= b43legacy_debugfs_open,		\

			.read	= b43legacy_debugfs_read,		\

			.write	= b43legacy_debugfs_write,		\

			.llseek = generic_file_llseek,			\

		},						\

		.file_struct_offset = offsetof(struct b43legacy_dfsentry, \

					       file_##name),	\

drivers/net/wireless/iwlwifi/iwl-debugfs.c

+3 −0
Original line number Diff line number Diff line
@@ -87,6 +87,7 @@ static int iwl_dbgfs_open_file_generic(struct inode *inode, struct file *file) 
static const struct file_operations iwl_dbgfs_##name##_ops = {          \

	.read = iwl_dbgfs_##name##_read,                       		\

	.open = iwl_dbgfs_open_file_generic,                    	\

	.llseek = generic_file_llseek,					\

};



#define DEBUGFS_WRITE_FILE_OPS(name)                                    \
@@ -94,6 +95,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ 
static const struct file_operations iwl_dbgfs_##name##_ops = {          \

	.write = iwl_dbgfs_##name##_write,                              \

	.open = iwl_dbgfs_open_file_generic,                    	\

	.llseek = generic_file_llseek,					\

};
@@ -104,6 +106,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ 
	.write = iwl_dbgfs_##name##_write,                              \

	.read = iwl_dbgfs_##name##_read,                                \

	.open = iwl_dbgfs_open_file_generic,                            \

	.llseek = generic_file_llseek,					\

};



static ssize_t iwl_dbgfs_tx_statistics_read(struct file *file,

drivers/net/wireless/libertas/debugfs.c

+1 −0
Original line number Diff line number Diff line
@@ -696,6 +696,7 @@ static ssize_t lbs_wrrf_write(struct file *file, 
	.open = open_file_generic, \

	.read = (fread), \

	.write = (fwrite), \

	.llseek = generic_file_llseek, \

}



struct lbs_debugfs_files {