Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 291717b6 authored by Dan Williams's avatar Dan Williams
Browse files

libnvdimm, of_pmem: workaround OF_NUMA=n build error



Stephen reports that an x86 allmodconfig build fails to build the
of_pmem driver due to a missing definition of of_node_to_nid(). That
helper is currently only exported in the OF_NUMA=y case. In other cases,
ppc and sparc, it is a weak symbol, and outside of those platforms it is
a static inline.

Until an OF_NUMA=n configuration can reliably support usage of
of_node_to_nid() in modules across architectures, mark this driver as
'bool' instead of 'tristate'.

Cc: Rob Herring <robh@kernel.org>
Cc: Oliver O'Halloran <oohall@gmail.com>
Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent bca811a7
Loading
Loading
Loading
Loading
+2 −1
Original line number Original line Diff line number Diff line
@@ -103,7 +103,8 @@ config NVDIMM_DAX
	  Select Y if unsure
	  Select Y if unsure


config OF_PMEM
config OF_PMEM
	tristate "Device-tree support for persistent memory regions"
	# FIXME: make tristate once OF_NUMA dependency removed
	bool "Device-tree support for persistent memory regions"
	depends on OF
	depends on OF
	default LIBNVDIMM
	default LIBNVDIMM
	help
	help