Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29130853 authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller
Browse files

dpaa_eth: fix error return code in dpaa_eth_probe() 



Fix to return a negative error code from the dpaa_bp_alloc() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c221fe40

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -2728,11 +2728,11 @@ static int dpaa_eth_probe(struct platform_device *pdev) 




	/* bp init */

	/* bp init */

	for (i = 0; i < DPAA_BPS_NUM; i++) {

	for (i = 0; i < DPAA_BPS_NUM; i++) {

		int err;



		dpaa_bps[i] = dpaa_bp_alloc(dev);

		dpaa_bps[i] = dpaa_bp_alloc(dev);

		if (IS_ERR(dpaa_bps[i]))

		if (IS_ERR(dpaa_bps[i])) {

			err = PTR_ERR(dpaa_bps[i]);

			goto free_dpaa_bps;

			goto free_dpaa_bps;

		}

		/* the raw size of the buffers used for reception */

		/* the raw size of the buffers used for reception */

		dpaa_bps[i]->raw_size = bpool_buffer_raw_size(i, DPAA_BPS_NUM);

		dpaa_bps[i]->raw_size = bpool_buffer_raw_size(i, DPAA_BPS_NUM);

		/* avoid runtime computations by keeping the usable size here */

		/* avoid runtime computations by keeping the usable size here */