Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28d6453a authored by DENG Qingfang's avatar DENG Qingfang Committed by Greg Kroah-Hartman
Browse files

net: dsa: mt7530: set CPU port to fallback mode 



commit 38152ea37d8bdaffa22603e0a5b5b86cfa8714c9 upstream.

Currently, setting a bridge's self PVID to other value and deleting
the default VID 1 renders untagged ports of that VLAN unable to talk to
the CPU port:

	bridge vlan add dev br0 vid 2 pvid untagged self
	bridge vlan del dev br0 vid 1 self
	bridge vlan add dev sw0p0 vid 2 pvid untagged
	bridge vlan del dev sw0p0 vid 1
	# br0 cannot send untagged frames out of sw0p0 anymore

That is because the CPU port is set to security mode and its PVID is
still 1, and untagged frames are dropped due to VLAN member violation.

Set the CPU port to fallback mode so untagged frames can pass through.

Fixes: 83163f7d ("net: dsa: mediatek: add VLAN support for MT7530")
Signed-off-by: default avatarDENG Qingfang <dqfext@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 01aeb332

drivers/net/dsa/mt7530.c

+8 −3
Original line number Diff line number Diff line
@@ -860,8 +860,13 @@ mt7530_port_set_vlan_aware(struct dsa_switch *ds, int port) 
		   PCR_MATRIX_MASK, PCR_MATRIX(MT7530_ALL_MEMBERS));



	/* Trapped into security mode allows packet forwarding through VLAN

	 * table lookup.

	 * table lookup. CPU port is set to fallback mode to let untagged

	 * frames pass through.

	 */

	if (dsa_is_cpu_port(ds, port))

		mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,

			   MT7530_PORT_FALLBACK_MODE);

	else

		mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,

			   MT7530_PORT_SECURITY_MODE);

drivers/net/dsa/mt7530.h

+6 −0
Original line number Diff line number Diff line
@@ -148,6 +148,12 @@ enum mt7530_port_mode { 
	/* Port Matrix Mode: Frames are forwarded by the PCR_MATRIX members. */

	MT7530_PORT_MATRIX_MODE = PORT_VLAN(0),



	/* Fallback Mode: Forward received frames with ingress ports that do

	 * not belong to the VLAN member. Frames whose VID is not listed on

	 * the VLAN table are forwarded by the PCR_MATRIX members.

	 */

	MT7530_PORT_FALLBACK_MODE = PORT_VLAN(1),



	/* Security Mode: Discard any frame due to ingress membership

	 * violation or VID missed on the VLAN table.

	 */