Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 281e8b2f authored by Amir Vadai's avatar Amir Vadai Committed by David S. Miller
Browse files

net/mlx4_en: Count HW buffer overrun only once 



RdropOvflw counts overrun of HW buffer, therefore should
be used for rx_fifo_errors only.

Currently RdropOvflw counter is mistakenly also set into
rx_missed_errors and rx_over_errors too, which makes the
device total dropped packets accounting to show wrong results.

Fix that. Use it for rx_fifo_errors only.

Fixes: c27a02cd ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC')
Signed-off-by: default avatarAmir Vadai <amir@vadai.me>
Signed-off-by: default avatarEugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent aac8d3c2

drivers/net/ethernet/mellanox/mlx4/en_port.c

+2 −2
Original line number Diff line number Diff line
@@ -238,11 +238,11 @@ int mlx4_en_DUMP_ETH_STATS(struct mlx4_en_dev *mdev, u8 port, u8 reset) 
	stats->collisions = 0;

	stats->rx_dropped = be32_to_cpu(mlx4_en_stats->RDROP);

	stats->rx_length_errors = be32_to_cpu(mlx4_en_stats->RdropLength);

	stats->rx_over_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw);

	stats->rx_over_errors = 0;

	stats->rx_crc_errors = be32_to_cpu(mlx4_en_stats->RCRC);

	stats->rx_frame_errors = 0;

	stats->rx_fifo_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw);

	stats->rx_missed_errors = be32_to_cpu(mlx4_en_stats->RdropOvflw);

	stats->rx_missed_errors = 0;

	stats->tx_aborted_errors = 0;

	stats->tx_carrier_errors = 0;

	stats->tx_fifo_errors = 0;