Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27d41d29 authored by Feras Daoud's avatar Feras Daoud Committed by Doug Ledford
Browse files

IB/ipoib: Change list_del to list_del_init in the tx object 



Since ipoib_cm_tx_start function and ipoib_cm_tx_reap function
belong to different work queues, they can run in parallel.
In this case if ipoib_cm_tx_reap calls list_del and release the
lock, ipoib_cm_tx_start may acquire it and call list_del_init
on the already deleted object.
Changing list_del to list_del_init in ipoib_cm_tx_reap fixes the problem.

Fixes: 839fcaba ("IPoIB: Connected mode experimental support")
Signed-off-by: default avatarFeras Daoud <ferasda@mellanox.com>
Signed-off-by: default avatarErez Shitrit <erezsh@mellanox.com>
Reviewed-by: default avatarAlex Vesker <valex@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent c586071d

drivers/infiniband/ulp/ipoib/ipoib_cm.c

+1 −1
Original line number Diff line number Diff line
@@ -1392,7 +1392,7 @@ static void ipoib_cm_tx_reap(struct work_struct *work) 


	while (!list_empty(&priv->cm.reap_list)) {

		p = list_entry(priv->cm.reap_list.next, typeof(*p), list);

		list_del(&p->list);

		list_del_init(&p->list);

		spin_unlock_irqrestore(&priv->lock, flags);

		netif_tx_unlock_bh(dev);

		ipoib_cm_tx_destroy(p);