Commit 279f64b7 authored Jul 11, 2014 by Arvid Brodin Committed by David S. Miller Jul 11, 2014

net/hsr: Remove left-over never-true conditional code.



MacAddressB is an array (unsigned char MacAddressB[ETH_ALEN]) and is allocated
as a part of *node_dst (which is a struct hsr_node). So the condition is always
false.

Detected by Dan Carpenter.

Signed-off-by: Arvid Brodin <arvid.brodin@alten.se>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 19278cab

net/hsr/hsr_framereg.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -290,10 +290,6 @@ void hsr_addr_subst_dest(struct hsr_node node_src, struct sk_buff skb,
		}
		if (port->type != node_dst->AddrB_port)
		return;
		if (!node_dst->MacAddressB) {
		WARN_ONCE(1, "%s: No MacAddressB\n", __func__);
		return;
		}

		ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->MacAddressB);
		}