Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25dd7e6a authored by Wang Chen's avatar Wang Chen Committed by David S. Miller
Browse files

hysdn: Kill directly reference of netdev->priv 



Usually, netdev->priv should point to the memory of private
data which is allocated in alloc_netdev().
netdev_priv() is used to get the address of the private data.

Change the netdev->priv pointer to another memory is wrong.
Use netdev->ml_priv for this case.

Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 52404881

drivers/isdn/hysdn/hysdn_net.c

+3 −3
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ static int 
net_open(struct net_device *dev)

{

	struct in_device *in_dev;

	hysdn_card *card = dev->priv;

	hysdn_card *card = dev->ml_priv;

	int i;



	netif_start_queue(dev);	/* start tx-queueing */
@@ -159,7 +159,7 @@ net_send_packet(struct sk_buff *skb, struct net_device *dev) 
	spin_unlock_irq(&lp->lock);



	if (lp->sk_count <= 3) {

		schedule_work(&((hysdn_card *) dev->priv)->irq_queue);

		schedule_work(&((hysdn_card *) dev->ml_priv)->irq_queue);

	}

	return (0);		/* success */

}				/* net_send_packet */
@@ -295,7 +295,7 @@ hysdn_net_create(hysdn_card * card) 
		kfree(dev);

		return (i);

	}

	dev->priv = card;	/* remember pointer to own data structure */

	dev->ml_priv = card;	/* remember pointer to own data structure */

	card->netif = dev;	/* setup the local pointer */



	if (card->debug_flags & LOG_NET_INIT)