Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25c83b84 authored by Lukas Wunner's avatar Lukas Wunner Committed by Bjorn Helgaas
Browse files

PCI: pciehp: Declare pciehp_enable/disable_slot() static 



No callers of pciehp_enable/disable_slot() outside of pciehp_ctrl.c
remain, so declare the functions static.  For now this requires forward
declarations.  Those can be eliminated by reshuffling functions once the
ongoing effort to refactor the driver has settled.

Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 1656716d

drivers/pci/hotplug/pciehp.h

+0 −2
Original line number Diff line number Diff line
@@ -177,8 +177,6 @@ void pciehp_queue_pushbutton_work(struct work_struct *work); 
struct controller *pcie_init(struct pcie_device *dev);

int pcie_init_notification(struct controller *ctrl);

void pcie_shutdown_notification(struct controller *ctrl);

int pciehp_enable_slot(struct slot *p_slot);

int pciehp_disable_slot(struct slot *p_slot);

void pcie_reenable_notification(struct controller *ctrl);

int pciehp_power_on_slot(struct slot *slot);

void pciehp_power_off_slot(struct slot *slot);

drivers/pci/hotplug/pciehp_ctrl.c

+5 −2
Original line number Diff line number Diff line
@@ -122,6 +122,9 @@ static void remove_board(struct slot *p_slot) 
	pciehp_green_led_off(p_slot);

}



static int pciehp_enable_slot(struct slot *slot);

static int pciehp_disable_slot(struct slot *slot);



void pciehp_request(struct controller *ctrl, int action)

{

	atomic_or(action, &ctrl->pending_events);
@@ -308,7 +311,7 @@ static int __pciehp_enable_slot(struct slot *p_slot) 
	return board_added(p_slot);

}



int pciehp_enable_slot(struct slot *slot)

static int pciehp_enable_slot(struct slot *slot)

{

	struct controller *ctrl = slot->ctrl;

	int ret;
@@ -342,7 +345,7 @@ static int __pciehp_disable_slot(struct slot *p_slot) 
	return 0;

}



int pciehp_disable_slot(struct slot *slot)

static int pciehp_disable_slot(struct slot *slot)

{

	int ret;