Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2593cd11 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: synaptics-rmi4 - fix endianness issue in SMBus transport 



The mapping table holds address in LE form, so we should convert it
to CPU when comparing it.

Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 8cf0adf2

drivers/input/rmi4/rmi_smbus.c

+5 −5
Original line number Diff line number Diff line
@@ -89,17 +89,17 @@ static int rmi_smb_get_command_code(struct rmi_transport_dev *xport, 


	mutex_lock(&rmi_smb->mappingtable_mutex);

	for (i = 0; i < RMI_SMB2_MAP_SIZE; i++) {

		if (rmi_smb->mapping_table[i].rmiaddr == rmiaddr) {

		struct mapping_table_entry *entry = &rmi_smb->mapping_table[i];



		if (le16_to_cpu(entry->rmiaddr) == rmiaddr) {

			if (isread) {

				if (rmi_smb->mapping_table[i].readcount

							== bytecount) {

				if (entry->readcount == bytecount) {

					*commandcode = i;

					retval = 0;

					goto exit;

				}

			} else {

				if (rmi_smb->mapping_table[i].flags &

							RMI_SMB2_MAP_FLAGS_WE) {

				if (entry->flags & RMI_SMB2_MAP_FLAGS_WE) {

					*commandcode = i;

					retval = 0;

					goto exit;