Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2585e7e5 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

rrunner: fix buffer overflow 



tx_skbuff is define as:
        struct sk_buff          *tx_skbuff[TX_RING_ENTRIES];

EVT_RING_ENTRIES is 64 and TX_RING_ENTRIES is 32.

This function is in a error path so that's why it wasn't noticed.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7ec4e7d3

drivers/net/rrunner.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1293,7 +1293,7 @@ static void rr_dump(struct net_device *dev) 




	printk("Error code 0x%x\n", readl(&regs->Fail1));

	printk("Error code 0x%x\n", readl(&regs->Fail1));





	index = (((readl(&regs->EvtPrd) >> 8) & 0xff ) - 1) % EVT_RING_ENTRIES;

	index = (((readl(&regs->EvtPrd) >> 8) & 0xff) - 1) % TX_RING_ENTRIES;

	cons = rrpriv->dirty_tx;

	cons = rrpriv->dirty_tx;

	printk("TX ring index %i, TX consumer %i\n",

	printk("TX ring index %i, TX consumer %i\n",

	       index, cons);

	       index, cons);