Commit 249f5a58 authored Jan 08, 2014 by Ricardo Ribalda Delgado Committed by Mauro Carvalho Chehab Mar 11, 2014

[media] vb2: Check if there are buffers before streamon



This patch adds a test preventing streamon() if there is no buffer
ready.

Without this patch, a user could call streamon() before
preparing any buffer. This leads to a situation where if he calls
close() before calling streamoff() the device is kept streaming.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

parent c897df0e

drivers/media/v4l2-core/videobuf2-core.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1832,6 +1832,11 @@ static int vb2_internal_streamon(struct vb2_queue *q, enum v4l2_buf_type type)
		return -EINVAL;
		}

		if (!q->num_buffers) {
		dprintk(1, "streamon: no buffers have been allocated\n");
		return -EINVAL;
		}

		/*
		* If any buffers were queued before streamon,
		* we can now pass them to driver for processing.