Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23a1cb11 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Maxime Ripard
Browse files

drm/sun4i: Fix tcon channel 0 comment about backporch = backporch + hsync 



The backporch programmed into the tcon registers is actually the
backporch + hsync length from the display timings, as indicated in
the interface timing diagrams found in the user manual of the A31
and A33 SoCs.

The comments for channel 0 mistakenly describe the discrepancy as
TCON backporch = frontporch + hsync.

Signed-off-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
parent 4c7f16d1

drivers/gpu/drm/sun4i/sun4i_tcon.c

+2 −2
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ void sun4i_tcon0_mode_set(struct sun4i_tcon *tcon, 


	/*

	 * This is called a backporch in the register documentation,

	 * but it really is the front porch + hsync

	 * but it really is the back porch + hsync

	 */

	bp = mode->crtc_htotal - mode->crtc_hsync_start;

	DRM_DEBUG_DRIVER("Setting horizontal total %d, backporch %d\n",
@@ -156,7 +156,7 @@ void sun4i_tcon0_mode_set(struct sun4i_tcon *tcon, 


	/*

	 * This is called a backporch in the register documentation,

	 * but it really is the front porch + hsync

	 * but it really is the back porch + hsync

	 */

	bp = mode->crtc_vtotal - mode->crtc_vsync_start;

	DRM_DEBUG_DRIVER("Setting vertical total %d, backporch %d\n",