Commit 2397134c authored Jul 20, 2018 by YueHaibing Committed by Ingo Molnar Jul 24, 2018

x86/platform/pcspeaker: Use PTR_ERR_OR_ZERO() to fix ptr_ret.cocci warning



The ptr_ret.cocci script generates the following warning:

  arch/x86/kernel/pcspeaker.c:12:8-14: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO() rather than an open-coded version to fix this.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: gregkh@linuxfoundation.org
Cc: kstewart@linuxfoundation.org
Cc: pombredanne@nexb.com
Link: http://lkml.kernel.org/r/20180720073213.14996-1-yuehaibing@huawei.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent d72e90f3

arch/x86/kernel/pcspeaker.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -9,6 +9,6 @@ static __init int add_pcspkr(void)

		pd = platform_device_register_simple("pcspkr", -1, NULL, 0);

		return IS_ERR(pd) ? PTR_ERR(pd) : 0;
		return PTR_ERR_OR_ZERO(pd);
		}
		device_initcall(add_pcspkr);