Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2329abfa authored by Rusty Russell's avatar Rusty Russell
Browse files

module_param: make bool parameters really bool (core code) 



module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 6d6a55ec

include/linux/init.h

+2 −1
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
#define _LINUX_INIT_H



#include <linux/compiler.h>

#include <linux/types.h>



/* These macros are used to mark some functions or 

 * initialized data (doesn't apply to uninitialized data)
@@ -156,7 +157,7 @@ void prepare_namespace(void); 


extern void (*late_time_init)(void);



extern int initcall_debug;

extern bool initcall_debug;



#endif

init/main.c

+1 −1
Original line number Diff line number Diff line
@@ -648,7 +648,7 @@ static void __init do_ctors(void) 
#endif

}



int initcall_debug;

bool initcall_debug;

core_param(initcall_debug, initcall_debug, bool, 0644);



static char msgbuf[64];

kernel/irq/internals.h

+1 −1
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ 


#define istate core_internal_state__do_not_mess_with_it



extern int noirqdebug;

extern bool noirqdebug;



/*

 * Bits used by threaded handlers:

kernel/irq/spurious.c

+1 −1
Original line number Diff line number Diff line
@@ -325,7 +325,7 @@ void note_interrupt(unsigned int irq, struct irq_desc *desc, 
	desc->irqs_unhandled = 0;

}



int noirqdebug __read_mostly;

bool noirqdebug __read_mostly;



int noirqdebug_setup(char *str)

{

kernel/printk.c

+4 −4
Original line number Diff line number Diff line
@@ -521,7 +521,7 @@ static void __call_console_drivers(unsigned start, unsigned end) 
	}

}



static int __read_mostly ignore_loglevel;

static bool __read_mostly ignore_loglevel;



static int __init ignore_loglevel_setup(char *str)

{
@@ -696,9 +696,9 @@ static void zap_locks(void) 
}



#if defined(CONFIG_PRINTK_TIME)

static int printk_time = 1;

static bool printk_time = 1;

#else

static int printk_time = 0;

static bool printk_time = 0;

#endif

module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
@@ -1098,7 +1098,7 @@ int update_console_cmdline(char *name, int idx, char *name_new, int idx_new, cha 
	return -1;

}



int console_suspend_enabled = 1;

bool console_suspend_enabled = 1;

EXPORT_SYMBOL(console_suspend_enabled);



static int __init console_suspend_disable(char *str)