Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2318b401 authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher
Browse files

i40e: remove unnecessary msleep() delay in i40e_free_vfs 



The delay was added because of a desire to ensure that the VF driver can
finish up removing. However, pci_disable_sriov already has its own
ssleep() call that will sleep for an entire second, so there is no
reason to add extra delay on top of this by using msleep here. In
practice, an msleep() won't have a huge impact on timing but there is no
real value in keeping it, so lets just simplify the code and remove it.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 707d088a

drivers/net/ethernet/intel/i40e/i40e_main.c

+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ static const char i40e_driver_string[] = 


#define DRV_VERSION_MAJOR 2

#define DRV_VERSION_MINOR 1

#define DRV_VERSION_BUILD 7

#define DRV_VERSION_BUILD 14

#define DRV_VERSION __stringify(DRV_VERSION_MAJOR) "." \

	     __stringify(DRV_VERSION_MINOR) "." \

	     __stringify(DRV_VERSION_BUILD)    DRV_KERN

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

+0 −2
Original line number Diff line number Diff line
@@ -1219,8 +1219,6 @@ void i40e_free_vfs(struct i40e_pf *pf) 
	else

		dev_warn(&pf->pdev->dev, "VFs are assigned - not disabling SR-IOV\n");



	msleep(20); /* let any messages in transit get finished up */



	/* free up VF resources */

	tmp = pf->num_alloc_vfs;

	pf->num_alloc_vfs = 0;

drivers/net/ethernet/intel/i40evf/i40evf_main.c

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ static const char i40evf_driver_string[] = 


#define DRV_VERSION_MAJOR 2

#define DRV_VERSION_MINOR 1

#define DRV_VERSION_BUILD 7

#define DRV_VERSION_BUILD 14

#define DRV_VERSION __stringify(DRV_VERSION_MAJOR) "." \

	     __stringify(DRV_VERSION_MINOR) "." \

	     __stringify(DRV_VERSION_BUILD) \