Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22805217 authored by Dāvis Mosāns's avatar Dāvis Mosāns Committed by James Bottomley
Browse files

mvsas: Fix NULL pointer dereference in mvs_slot_task_free 

When pci_pool_alloc fails in mvs_task_prep then task->lldd_task stays
NULL but it's later used in mvs_abort_task as slot which is passed
to mvs_slot_task_free causing NULL pointer dereference.

Just return from mvs_slot_task_free when passed with NULL slot.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=101891


Signed-off-by: default avatarDāvis Mosāns <davispuh@gmail.com>
Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent 15e3d5a2

drivers/scsi/mvsas/mv_sas.c

+2 −0
Original line number Diff line number Diff line
@@ -887,6 +887,8 @@ static void mvs_slot_free(struct mvs_info *mvi, u32 rx_desc) 
static void mvs_slot_task_free(struct mvs_info *mvi, struct sas_task *task,

			  struct mvs_slot_info *slot, u32 slot_idx)

{

	if (!slot)

		return;

	if (!slot->task)

		return;

	if (!sas_protocol_ata(task->task_proto))