Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21a35427 authored by Axel Lin's avatar Axel Lin Committed by Matthew Garrett
Browse files

platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check 



Only pin 0-7 support input, so the valid offset range should be 0 ~ 7.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMatthew Garrett <matthew.garrett@nebula.com>
parent 963649d7

drivers/platform/x86/intel_pmic_gpio.c

+2 −2
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ static void pmic_program_irqtype(int gpio, int type) 


static int pmic_gpio_direction_input(struct gpio_chip *chip, unsigned offset)

{

	if (offset > 8) {

	if (offset >= 8) {

		pr_err("only pin 0-7 support input\n");

		return -1;/* we only have 8 GPIO can use as input */

	}
@@ -130,7 +130,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned offset) 
	int ret;



	/* we only have 8 GPIO pins we can use as input */

	if (offset > 8)

	if (offset >= 8)

		return -EOPNOTSUPP;

	ret = intel_scu_ipc_ioread8(GPIO0 + offset, &r);

	if (ret < 0)