Commit 21572ea5 authored Mar 25, 2008 by Tejun Heo Committed by Jeff Garzik Apr 17, 2008

libata: drop ata_dev_select() from ata_dev_read_id



There is no reason to issue device select in read_id, it will be done
by ops->qc_issue() when IDENTIFY[_PACKET] is issued via
ata_exec_internal().

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent a1efdaba

drivers/ata/libata-core.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2156,7 +2156,6 @@ int ata_dev_read_id(struct ata_device dev, unsigned int p_class,
		if (ata_msg_ctl(ap))
		ata_dev_printk(dev, KERN_DEBUG, "%s: ENTER\n", __func__);

		ata_dev_select(ap, dev->devno, 1, 1); /* select device 0/1 */
		retry:
		ata_tf_init(dev, &tf);