Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 212fb575 authored by Wey-Yi Guy's avatar Wey-Yi Guy Committed by John W. Linville
Browse files

iwlwifi: indicate uCode type when fail dump error/event log 



error_event_table_ptr is only set upon receipt of REPLY_ALIVE. Until
then both event log and error log will fail. Add information to indicate
which uCode encounter the failure case.

Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent bd3709b5

drivers/net/wireless/iwlwifi/iwl-agn.c

+6 −2
Original line number Original line Diff line number Diff line
@@ -1662,7 +1662,9 @@ void iwl_dump_nic_error_log(struct iwl_priv *priv) 
		base = le32_to_cpu(priv->card_alive.error_event_table_ptr);

		base = le32_to_cpu(priv->card_alive.error_event_table_ptr);





	if (!priv->cfg->ops->lib->is_valid_rtc_data_addr(base)) {

	if (!priv->cfg->ops->lib->is_valid_rtc_data_addr(base)) {

		IWL_ERR(priv, "Not valid error log pointer 0x%08X\n", base);

		IWL_ERR(priv,

			"Not valid error log pointer 0x%08X for %s uCode\n",

			base, (priv->ucode_type == UCODE_INIT) ? "Init" : "RT");

		return;

		return;

	}

	}
@@ -1807,7 +1809,9 @@ void iwl_dump_nic_event_log(struct iwl_priv *priv, bool full_log) 
		base = le32_to_cpu(priv->card_alive.log_event_table_ptr);

		base = le32_to_cpu(priv->card_alive.log_event_table_ptr);





	if (!priv->cfg->ops->lib->is_valid_rtc_data_addr(base)) {

	if (!priv->cfg->ops->lib->is_valid_rtc_data_addr(base)) {

		IWL_ERR(priv, "Invalid event log pointer 0x%08X\n", base);

		IWL_ERR(priv,

			"Invalid event log pointer 0x%08X for %s uCode\n",

			base, (priv->ucode_type == UCODE_INIT) ? "Init" : "RT");

		return;

		return;

	}

	}