Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 211f658b authored by Hans de Goede's avatar Hans de Goede Committed by Felipe Balbi
Browse files

usb: dwc3: pci: Use devm functions to get the phy GPIOs 



Even though we only use them once, it is better to not put/release
the GPIOs immediately after use, so that others cannot claim them.

Use devm functions to get the phy GPIOs, so that they will be
automatically released when were unbound from the device and
remove the gpio_put calls.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 7740d04d

drivers/usb/dwc3/dwc3-pci.c

+4 −4
Original line number Diff line number Diff line
@@ -177,20 +177,20 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc) 
			 * put the gpio descriptors again here because the phy driver

			 * might want to grab them, too.

			 */

			gpio = gpiod_get_optional(&pdev->dev, "cs", GPIOD_OUT_LOW);

			gpio = devm_gpiod_get_optional(&pdev->dev, "cs",

						       GPIOD_OUT_LOW);

			if (IS_ERR(gpio))

				return PTR_ERR(gpio);



			gpiod_set_value_cansleep(gpio, 1);

			gpiod_put(gpio);



			gpio = gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW);

			gpio = devm_gpiod_get_optional(&pdev->dev, "reset",

						       GPIOD_OUT_LOW);

			if (IS_ERR(gpio))

				return PTR_ERR(gpio);



			if (gpio) {

				gpiod_set_value_cansleep(gpio, 1);

				gpiod_put(gpio);

				usleep_range(10000, 11000);

			}

		}