Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20ba09b9 authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Linus Torvalds
Browse files

spi_mpc83xx: get rid of magic numbers 



Magic-numbers-R-Evil

Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: default avatarKumar Gala <galak@kernel.crashing.org>
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 49bb2300

drivers/spi/spi_mpc83xx.c

+3 −2
Original line number Diff line number Diff line
@@ -153,7 +153,8 @@ static void mpc83xx_spi_chipselect(struct spi_device *spi, int value) 
			len = len - 1;



		/* mask out bits we are going to set */

		regval &= ~0x38ff0000;

		regval &= ~(SPMODE_CP_BEGIN_EDGECLK | SPMODE_CI_INACTIVEHIGH |

			    SPMODE_LEN(0xF) | SPMODE_DIV16 | SPMODE_PM(0xF));



		if (spi->mode & SPI_CPHA)

			regval |= SPMODE_CP_BEGIN_EDGECLK;
@@ -248,7 +249,7 @@ int mpc83xx_spi_setup_transfer(struct spi_device *spi, struct spi_transfer *t) 
	regval = mpc83xx_spi_read_reg(&mpc83xx_spi->base->mode);



	/* Mask out bits_per_wordgth */

	regval &= 0xff0fffff;

	regval &= ~SPMODE_LEN(0xF);

	regval |= SPMODE_LEN(bits_per_word);



	/* Turn off SPI unit prior changing mode */