Commit 208c66f2 authored Apr 27, 2017 by Tobin C. Harding Committed by Greg Kroah-Hartman Apr 28, 2017

staging: ks7010: remove unnecessary address check



Currently source and destination ethernet addresses are checked twice,
once in hostif_data_indication() and then again in
hostif_data_indication_wpa(). The second of these functions is called
from the first right after the address check is done. This check is a
duplicate and is unnecessary.

Remove unnecessary duplicate address check.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6d27f590

drivers/staging/ks7010/ks_hostif.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -326,10 +326,6 @@ int hostif_data_indication_wpa(struct ks_wlan_private *priv,
		eth_hdr = (struct ether_hdr *)(priv->rxp);
		eth_proto = ntohs(eth_hdr->h_proto);

		/* source address check */
		if (memcmp(&eth_hdr->h_source[0], &priv->eth_addr[0], ETH_ALEN) == 0)
		return 0;

		if (eth_hdr->h_dest_snap != eth_hdr->h_source_snap) {
		DPRINTK(1, "invalid data format\n");
		priv->nstats.rx_errors++;