Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2040fce8 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: detect wrong layout 



Previous mkfs.f2fs allows small partition inappropriately, so f2fs should detect
that as well.

Refer this in f2fs-tools.

mkfs.f2fs: detect small partition by overprovision ratio and # of segments

Reported-and-Tested-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent f455c8a5

fs/f2fs/segment.h

+2 −0
Original line number Diff line number Diff line
@@ -18,6 +18,8 @@ 
#define DEF_RECLAIM_PREFREE_SEGMENTS	5	/* 5% over total segments */

#define DEF_MAX_RECLAIM_PREFREE_SEGMENTS	4096	/* 8GB in maximum */



#define F2FS_MIN_SEGMENTS	9 /* SB + 2 (CP + SIT + NAT) + SSA + MAIN */



/* L: Logical segment # in volume, R: Relative segment # in main area */

#define GET_L2R_SEGNO(free_i, segno)	(segno - free_i->start_segno)

#define GET_R2L_SEGNO(free_i, segno)	(segno + free_i->start_segno)

fs/f2fs/super.c

+11 −0
Original line number Diff line number Diff line
@@ -1452,6 +1452,7 @@ int sanity_check_ckpt(struct f2fs_sb_info *sbi) 
	unsigned int total, fsmeta;

	struct f2fs_super_block *raw_super = F2FS_RAW_SUPER(sbi);

	struct f2fs_checkpoint *ckpt = F2FS_CKPT(sbi);

	unsigned int ovp_segments, reserved_segments;



	total = le32_to_cpu(raw_super->segment_count);

	fsmeta = le32_to_cpu(raw_super->segment_count_ckpt);
@@ -1463,6 +1464,16 @@ int sanity_check_ckpt(struct f2fs_sb_info *sbi) 
	if (unlikely(fsmeta >= total))

		return 1;



	ovp_segments = le32_to_cpu(ckpt->overprov_segment_count);

	reserved_segments = le32_to_cpu(ckpt->rsvd_segment_count);



	if (unlikely(fsmeta < F2FS_MIN_SEGMENTS ||

			ovp_segments == 0 || reserved_segments == 0)) {

		f2fs_msg(sbi->sb, KERN_ERR,

			"Wrong layout: check mkfs.f2fs version");

		return 1;

	}



	if (unlikely(f2fs_cp_error(sbi))) {

		f2fs_msg(sbi->sb, KERN_ERR, "A bug case: need to run fsck");

		return 1;