Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ff6fee5 authored by Oleg Nesterov's avatar Oleg Nesterov
Browse files

uprobes: Change filter_chain() to iterate ->consumers list 



Now that it safe to use ->consumer_rwsem under ->mmap_sem we can
almost finish the implementation of filter_chain(). It still lacks
the actual uc->filter(...) call but othewrwise it is ready, just
it pretends that ->filter() always returns true.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
parent e591c8d7

kernel/events/uprobes.c

+13 −8
Original line number Diff line number Diff line
@@ -614,14 +614,19 @@ static int prepare_uprobe(struct uprobe *uprobe, struct file *file, 


static bool filter_chain(struct uprobe *uprobe)

{

	/*

	 * TODO:

	 *	for_each_consumer(uc)

	 *		if (uc->filter(...))

	 *			return true;

	 *	return false;

	 */

	return uprobe->consumers != NULL;

	struct uprobe_consumer *uc;

	bool ret = false;



	down_read(&uprobe->consumer_rwsem);

	for (uc = uprobe->consumers; uc; uc = uc->next) {

		/* TODO: ret = uc->filter(...) */

		ret = true;

		if (ret)

			break;

	}

	up_read(&uprobe->consumer_rwsem);



	return ret;

}



static int