Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ed98ed5 authored by Manish Chopra's avatar Manish Chopra Committed by David S. Miller
Browse files

qlcnic: Fix SR-IOV configuration 



o Interface needs to be brought down and up while configuring SR-IOV.
  Protect interface up/down using rtnl_lock()/rtnl_unlock()

Signed-off-by: default avatarManish Chopra <manish.chopra@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7167cf0e

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c

+7 −1
Original line number Diff line number Diff line
@@ -397,6 +397,7 @@ static int qlcnic_pci_sriov_disable(struct qlcnic_adapter *adapter) 
{

	struct net_device *netdev = adapter->netdev;



	rtnl_lock();

	if (netif_running(netdev))

		__qlcnic_down(adapter, netdev);
@@ -407,12 +408,15 @@ static int qlcnic_pci_sriov_disable(struct qlcnic_adapter *adapter) 
	/* After disabling SRIOV re-init the driver in default mode

	   configure opmode based on op_mode of function

	 */

	if (qlcnic_83xx_configure_opmode(adapter))

	if (qlcnic_83xx_configure_opmode(adapter)) {

		rtnl_unlock();

		return -EIO;

	}



	if (netif_running(netdev))

		__qlcnic_up(adapter, netdev);



	rtnl_unlock();

	return 0;

}
@@ -533,6 +537,7 @@ static int qlcnic_pci_sriov_enable(struct qlcnic_adapter *adapter, int num_vfs) 
		return -EIO;

	}



	rtnl_lock();

	if (netif_running(netdev))

		__qlcnic_down(adapter, netdev);
@@ -555,6 +560,7 @@ static int qlcnic_pci_sriov_enable(struct qlcnic_adapter *adapter, int num_vfs) 
		__qlcnic_up(adapter, netdev);



error:

	rtnl_unlock();

	return err;

}