Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d978dac authored by Jean Delvare's avatar Jean Delvare Committed by Dave Airlie
Browse files

drm/radeon: Fix stack data leak 



Always zero-init a structure on the stack which is returned by a
function. Otherwise you may leak random stack data from previous
function calls.

This fixes the following warning I was seeing:
  CC [M]  drivers/gpu/drm/radeon/radeon_atombios.o
drivers/gpu/drm/radeon/radeon_atombios.c: In function "radeon_atom_get_hpd_info_from_gpio":
drivers/gpu/drm/radeon/radeon_atombios.c:261: warning: "hpd.plugged_state" is used uninitialized in this function

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 2cbeb4ef

drivers/gpu/drm/radeon/radeon_atombios.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -226,6 +226,8 @@ static struct radeon_hpd radeon_atom_get_hpd_info_from_gpio(struct radeon_device 
	struct radeon_hpd hpd;

	struct radeon_hpd hpd;

	u32 reg;

	u32 reg;





	memset(&hpd, 0, sizeof(struct radeon_hpd));



	if (ASIC_IS_DCE4(rdev))

	if (ASIC_IS_DCE4(rdev))

		reg = EVERGREEN_DC_GPIO_HPD_A;

		reg = EVERGREEN_DC_GPIO_HPD_A;

	else

	else