Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1cc9bd68 authored by Steve French's avatar Steve French
Browse files

make convert_delimiter use strchr instead of open-coding it 



Take advantage of accelerated strchr() on arches that support it.

Also, no caller ever passes in a NULL pointer. Get rid of the unneeded
NULL pointer check.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
parent b979aaa1

fs/cifs/cifsglob.h

+4 −9
Original line number Diff line number Diff line
@@ -1064,21 +1064,16 @@ static inline char CIFS_DIR_SEP(const struct cifs_sb_info *cifs_sb) 
static inline void

convert_delimiter(char *path, char delim)

{

	int i;

	char old_delim;



	if (path == NULL)

		return;

	char old_delim, *pos;



	if (delim == '/')

		old_delim = '\\';

	else

		old_delim = '/';



	for (i = 0; path[i] != '\0'; i++) {

		if (path[i] == old_delim)

			path[i] = delim;

	}

	pos = path;

	while ((pos = strchr(pos, old_delim)))

		*pos = delim;

}



#ifdef CONFIG_CIFS_STATS