Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c789249 authored by Chengguang Xu's avatar Chengguang Xu Committed by Ilya Dryomov
Browse files

ceph: fix potential memory leak in init_caches() 



There is lack of cache destroy operation for ceph_file_cachep
when failing from fscache register.

Signed-off-by: default avatarChengguang Xu <cgxu519@icloud.com>
Reviewed-by: default avatarIlya Dryomov <idryomov@gmail.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 18106734

fs/ceph/super.c

+6 −3
Original line number Diff line number Diff line
@@ -713,14 +713,17 @@ static int __init init_caches(void) 
		goto bad_dentry;



	ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD);



	if (!ceph_file_cachep)

		goto bad_file;



	if ((error = ceph_fscache_register()))

		goto bad_file;

	error = ceph_fscache_register();

	if (error)

		goto bad_fscache;



	return 0;



bad_fscache:

	kmem_cache_destroy(ceph_file_cachep);

bad_file:

	kmem_cache_destroy(ceph_dentry_cachep);

bad_dentry: