Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c356ec5 authored by Vasyl Gomonovych's avatar Vasyl Gomonovych Committed by Martin K. Petersen
Browse files

scsi: lpfc: fix kzalloc-simple.cocci warnings 



drivers/scsi/lpfc/lpfc_debugfs.c:5460:22-29: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset
drivers/scsi/lpfc/lpfc_debugfs.c:2230:20-27: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset

 Use kzalloc rather than kmalloc followed by memset with 0

Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Signed-off-by: default avatarVasyl Gomonovych <gomonovych@gmail.com>
Acked-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 62d2f774

drivers/scsi/lpfc/lpfc_debugfs.c

+2 −7
Original line number Diff line number Diff line
@@ -2227,7 +2227,7 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf, 
	kfree(phba->nvmeio_trc);



	/* Allocate new trace buffer and initialize */

	phba->nvmeio_trc = kmalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) *

	phba->nvmeio_trc = kzalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) *

				    sz), GFP_KERNEL);

	if (!phba->nvmeio_trc) {

		lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
@@ -2235,8 +2235,6 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf, 
				"nvmeio_trc buffer\n");

		return -ENOMEM;

	}

	memset(phba->nvmeio_trc, 0,

	       (sizeof(struct lpfc_debugfs_nvmeio_trc) * sz));

	atomic_set(&phba->nvmeio_trc_cnt, 0);

	phba->nvmeio_trc_on = 0;

	phba->nvmeio_trc_output_idx = 0;
@@ -5457,7 +5455,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
			phba->nvmeio_trc_size = lpfc_debugfs_max_nvmeio_trc;



			/* Allocate trace buffer and initialize */

			phba->nvmeio_trc = kmalloc(

			phba->nvmeio_trc = kzalloc(

				(sizeof(struct lpfc_debugfs_nvmeio_trc) *

				phba->nvmeio_trc_size), GFP_KERNEL);
@@ -5467,9 +5465,6 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
						"nvmeio_trc buffer\n");

				goto nvmeio_off;

			}

			memset(phba->nvmeio_trc, 0,

			       (sizeof(struct lpfc_debugfs_nvmeio_trc) *

			       phba->nvmeio_trc_size));

			phba->nvmeio_trc_on = 1;

			phba->nvmeio_trc_output_idx = 0;

			phba->nvmeio_trc = NULL;