Commit 1c2de820 authored Dec 18, 2013 by Yongjian Xu Committed by Greg Kroah-Hartman Dec 18, 2013

char: Int overflow in lp_do_ioctl().



arg comes from user-space, so int overflow may occur:
	LP_TIME(minor) = arg * HZ/100;

Reported-by: Yongjian Xu <xuyongjiande@gmail.com>
Suggested-by: Qixue Xiao <s2exqx@gmail.com>
Signed-off-by: Yu Chen <chyyuu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 138a6d7e

drivers/char/lp.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -587,6 +587,8 @@ static int lp_do_ioctl(unsigned int minor, unsigned int cmd,
		return -ENODEV;
		switch ( cmd ) {
		case LPTIME:
		if (arg > UINT_MAX / HZ)
		return -EINVAL;
		LP_TIME(minor) = arg * HZ/100;
		break;
		case LPCHAR: