Commit 1bc4d68b authored May 10, 2018 by Andres Rodriguez Committed by Greg Kroah-Hartman May 14, 2018

ath10k: re-enable the firmware fallback mechanism for testmode



The ath10k testmode uses request_firmware_direct() in order to avoid
producing firmware load warnings. Disabling the fallback mechanism was a
side effect of disabling warnings.

We now have a new API that allows us to avoid warnings while keeping the
fallback mechanism enabled. So use that instead.

Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c8e02802

drivers/net/wireless/ath/ath10k/testmode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -157,7 +157,7 @@ static int ath10k_tm_fetch_utf_firmware_api_1(struct ath10k *ar,
		ar->hw_params.fw.dir, ATH10K_FW_UTF_FILE);

		/* load utf firmware image */
		ret = request_firmware_direct(&fw_file->firmware, filename, ar->dev);
		ret = firmware_request_nowarn(&fw_file->firmware, filename, ar->dev);
		ath10k_dbg(ar, ATH10K_DBG_TESTMODE, "testmode fw request '%s': %d\n",
		filename, ret);