Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ab90587 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] tlg2300: index is unsigned, so never below zero 



drivers/media/usb/tlg2300/pd-video.c:891:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/media/usb/tlg2300/pd-video.c:926:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Cc: Huang Shijie <shijie8@gmail.com>
Cc: Kang Yong <kangyong@telegent.com>
Cc: Zhang Xiaobing <xbzhang@telegent.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2869a318

drivers/media/usb/tlg2300/pd-video.c

+2 −2
Original line number Diff line number Diff line
@@ -888,7 +888,7 @@ static int vidioc_enum_input(struct file *file, void *fh, struct v4l2_input *in) 
{

	struct front_face *front = fh;



	if (in->index < 0 || in->index >= POSEIDON_INPUTS)

	if (in->index >= POSEIDON_INPUTS)

		return -EINVAL;

	strcpy(in->name, pd_inputs[in->index].name);

	in->type  = V4L2_INPUT_TYPE_TUNER;
@@ -923,7 +923,7 @@ static int vidioc_s_input(struct file *file, void *fh, unsigned int i) 
	struct poseidon *pd = front->pd;

	s32 ret, cmd_status;



	if (i < 0 || i >= POSEIDON_INPUTS)

	if (i >= POSEIDON_INPUTS)

		return -EINVAL;

	ret = send_set_req(pd, SGNL_SRC_SEL,

			pd_inputs[i].tlg_src, &cmd_status);