Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 187d5edf authored by Andrzej Hajda's avatar Andrzej Hajda Committed by Inki Dae
Browse files

drm/exynos/ipp: remove incorrect checks of list_first_entry result 



list_first_entry does not return NULL on empty list so this check
does not make sense. Moreover there is already code which prevents calling
list_first_entry on empty lists.

Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 73b00232

drivers/gpu/drm/exynos/exynos_drm_ipp.c

+0 −15
Original line number Diff line number Diff line
@@ -1277,11 +1277,6 @@ static int ipp_start_property(struct exynos_drm_ippdrv *ippdrv, 


			m_node = list_first_entry(head,

				struct drm_exynos_ipp_mem_node, list);

			if (!m_node) {

				DRM_ERROR("failed to get node.\n");

				ret = -EFAULT;

				goto err_unlock;

			}



			DRM_DEBUG_KMS("m_node[0x%x]\n", (int)m_node);
@@ -1539,11 +1534,6 @@ static int ipp_send_event(struct exynos_drm_ippdrv *ippdrv, 


			m_node = list_first_entry(head,

				struct drm_exynos_ipp_mem_node, list);

			if (!m_node) {

				DRM_ERROR("empty memory node.\n");

				ret = -ENOMEM;

				goto err_mem_unlock;

			}



			tbuf_id[i] = m_node->buf_id;

			DRM_DEBUG_KMS("%s buf_id[%d]\n",
@@ -1580,11 +1570,6 @@ static int ipp_send_event(struct exynos_drm_ippdrv *ippdrv, 


		m_node = list_first_entry(head,

			struct drm_exynos_ipp_mem_node, list);

		if (!m_node) {

			DRM_ERROR("empty memory node.\n");

			ret = -ENOMEM;

			goto err_mem_unlock;

		}



		tbuf_id[EXYNOS_DRM_OPS_SRC] = m_node->buf_id;