Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18442cf2 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

__group_complete_signal: eliminate unneeded wakeup of ->group_exit_task 



Cleanup.  __group_complete_signal() wakes up ->group_exit_task twice.  The
second wakeup's state includes TASK_UNINTERRUPTIBLE, which is not very
appropriate.

Change the code to pass the "correct" argument to signal_wake_up() and kill
now unneeded wake_up_process().

Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 442a10cf

kernel/signal.c

+4 −7
Original line number Diff line number Diff line
@@ -909,8 +909,7 @@ __group_complete_signal(int sig, struct task_struct *p) 
			do {

				sigaddset(&t->pending.signal, SIGKILL);

				signal_wake_up(t, 1);

				t = next_thread(t);

			} while (t != p);

			} while_each_thread(p, t);

			return;

		}
@@ -928,13 +927,11 @@ __group_complete_signal(int sig, struct task_struct *p) 
		rm_from_queue(SIG_KERNEL_STOP_MASK, &p->signal->shared_pending);

		p->signal->group_stop_count = 0;

		p->signal->group_exit_task = t;

		t = p;

		p = t;

		do {

			p->signal->group_stop_count++;

			signal_wake_up(t, 0);

			t = next_thread(t);

		} while (t != p);

		wake_up_process(p->signal->group_exit_task);

			signal_wake_up(t, t == p);

		} while_each_thread(p, t);

		return;

	}