Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 174427c1 authored by Maxime Ripard's avatar Maxime Ripard Committed by Vinod Koul
Browse files

dmaengine: sun6i: Free the interrupt before killing the tasklet 



There's still a small window between the call to sun6i_kill_tasklet and the end
of the driver remove function where a spurious interrupt might trigger, and
start using deallocated resources.

Replace the call to synchronize_irq by a free_irq, so that we're sure that we
won't get any further interrupts when we're deallocating resources.

Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 92e4a3bf

drivers/dma/sun6i-dma.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -836,8 +836,8 @@ static inline void sun6i_kill_tasklet(struct sun6i_dma_dev *sdev) 
	/* Prevent spurious interrupts from scheduling the tasklet */

	/* Prevent spurious interrupts from scheduling the tasklet */

	atomic_inc(&sdev->tasklet_shutdown);

	atomic_inc(&sdev->tasklet_shutdown);





	/* Make sure all interrupts are handled */

	/* Make sure we won't have any further interrupts */

	synchronize_irq(sdev->irq);

	devm_free_irq(sdev->slave.dev, sdev->irq, sdev);





	/* Actually prevent the tasklet from being scheduled */

	/* Actually prevent the tasklet from being scheduled */

	tasklet_kill(&sdev->task);

	tasklet_kill(&sdev->task);