Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 173bcc60 authored by Zhenyu Wang's avatar Zhenyu Wang
Browse files

drm/i915/gvt: Fix shift for cmd data size 



This is to fix smatch warning on

     drivers/gpu/drm/i915/gvt/cmd_parser.c:1421 cmd_handler_mi_op_2f()
     warn: shift has higher precedence than mask

We need bits 20-19 mask for data size.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarZhenyu Wang <zhenyuw@linux.intel.com>
parent e95433c7

drivers/gpu/drm/i915/gvt/cmd_parser.c

+2 −2
Original line number Diff line number Diff line
@@ -1418,8 +1418,8 @@ static int cmd_handler_mi_op_2e(struct parser_exec_state *s) 
static int cmd_handler_mi_op_2f(struct parser_exec_state *s)

{

	int gmadr_bytes = s->vgpu->gvt->device_info.gmadr_bytes_in_cmd;

	int op_size = ((1 << (cmd_val(s, 0) & GENMASK(20, 19) >> 19)) *

			sizeof(u32));

	int op_size = (1 << ((cmd_val(s, 0) & GENMASK(20, 19)) >> 19)) *

			sizeof(u32);

	unsigned long gma, gma_high;

	int ret = 0;