Commit 167f5594 authored Mar 06, 2018 by Oliver O'Halloran Committed by Dan Williams Mar 06, 2018

kernel/memremap: Remove stale devres_free() call



devm_memremap_pages() was re-worked in e8d51348 "memremap: change
devm_memremap_pages interface to use struct dev_pagemap" to take a
caller allocated struct dev_pagemap as a function parameter. A call to
devres_free() was left in the error cleanup path which results in a
kernel panic if the remap fails for some reason. Remove it to fix the
panic and let devm_memremap_pages() fail gracefully.

Fixes: e8d51348 ("memremap: change devm_memremap_pages interface...")
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 661e50bc

kernel/memremap.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -427,7 +427,6 @@ void devm_memremap_pages(struct device dev, struct dev_pagemap *pgmap)
		err_pfn_remap:
		err_radix:
		pgmap_radix_release(res, pgoff);
		devres_free(pgmap);
		return ERR_PTR(error);
		}
		EXPORT_SYMBOL(devm_memremap_pages);