Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15cb6af8 authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by Mauro Carvalho Chehab
Browse files

[media] cx231xx: simplify argument passing to cx231xx_init_dev() 



The 'struct cx231xx *' pointer was passed by reference to the
cx231xx_init_dev() function, for no reason. Instead, just pass it by
value, which is much more logical and simple.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 9e94136d

drivers/media/video/cx231xx/cx231xx-cards.c

+2 −3
Original line number Diff line number Diff line
@@ -868,10 +868,9 @@ void cx231xx_release_resources(struct cx231xx *dev) 
 * cx231xx_init_dev()

 * allocates and inits the device structs, registers i2c bus and v4l device

 */

static int cx231xx_init_dev(struct cx231xx **devhandle, struct usb_device *udev,

static int cx231xx_init_dev(struct cx231xx *dev, struct usb_device *udev,

			    int minor)

{

	struct cx231xx *dev = *devhandle;

	int retval = -ENOMEM;

	int errCode;

	unsigned int maxh, maxw;
@@ -1154,7 +1153,7 @@ static int cx231xx_usb_probe(struct usb_interface *interface, 
		return -EIO;

	}

	/* allocate device struct */

	retval = cx231xx_init_dev(&dev, udev, nr);

	retval = cx231xx_init_dev(dev, udev, nr);

	if (retval) {

		clear_bit(dev->devno, &cx231xx_devused);

		v4l2_device_unregister(&dev->v4l2_dev);