Commit 151586d0 authored Jul 12, 2009 by Rakib Mullick Committed by Ingo Molnar Jul 13, 2009

x86: Fix false positive section mismatch in es7000_32.c



The variable apic_es7000_cluster references the function __cpuinit
wakeup_secondary_cpu_via_mip() from a noninit section. So we've been
warned by the following warning. To avoid possible collision between
init/noninit, its best to mark the variable as __refdata.

We were warned by the following warning:

  LD      arch/x86/kernel/apic/built-in.o
  WARNING: arch/x86/kernel/apic/built-in.o(.data+0x198c): Section
  mismatch in reference from the variable apic_es7000_cluster to the
  function .cpuinit.text:wakeup_secondary_cpu_via_mip()

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
LKML-Reference: <b9df5fa10907120404k6279a10ch5e9682432272706f@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent a1a08d1c

arch/x86/kernel/apic/es7000_32.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -652,7 +652,8 @@ static int es7000_mps_oem_check_cluster(struct mpc_table mpc, char oem,
	return ret && es7000_apic_is_cluster();		return ret && es7000_apic_is_cluster();
	}		}

	struct apic apic_es7000_cluster = {		/* We've been warned by a false positive warning.Use __refdata to keep calm. */
			struct apic __refdata apic_es7000_cluster = {

	.name = "es7000",		.name = "es7000",
	.probe = probe_es7000,		.probe = probe_es7000,