Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14c52aca authored by Ronnie Sahlberg's avatar Ronnie Sahlberg Committed by Greg Kroah-Hartman
Browse files

cifs: allow guest mounts to work for smb3.11 



commit e71ab2aa06f731a944993120b0eef1556c63b81c upstream.

Fix Guest/Anonymous sessions so that they work with SMB 3.11.

The commit noted below tightened the conditions and forced signing for
the SMB2-TreeConnect commands as per MS-SMB2.
However, this should only apply to normal user sessions and not for
Guest/Anonumous sessions.

Fixes: 6188f28b ("Tree connect for SMB3.1.1 must be signed for non-encrypted shares")

Signed-off-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 36d52f5b

fs/cifs/smb2pdu.c

+6 −2
Original line number Diff line number Diff line
@@ -1500,9 +1500,13 @@ SMB2_tcon(const unsigned int xid, struct cifs_ses *ses, const char *tree, 
	iov[1].iov_base = unc_path;

	iov[1].iov_len = unc_path_len;



	/* 3.11 tcon req must be signed if not encrypted. See MS-SMB2 3.2.4.1.1 */

	/*

	 * 3.11 tcon req must be signed if not encrypted. See MS-SMB2 3.2.4.1.1

	 * unless it is guest or anonymous user. See MS-SMB2 3.2.5.3.1

	 */

	if ((ses->server->dialect == SMB311_PROT_ID) &&

	    !smb3_encryption_required(tcon))

	    !smb3_encryption_required(tcon) &&

	    !(ses->session_flags & (SMB2_SESSION_FLAG_IS_GUEST|SMB2_SESSION_FLAG_IS_NULL)))

		req->sync_hdr.Flags |= SMB2_FLAGS_SIGNED;



	memset(&rqst, 0, sizeof(struct smb_rqst));