Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14150723 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Mauro Carvalho Chehab
Browse files

[media] vb2: include lengths in dmabuf qbuf debug message 



If the VIDIOC_QBUF ioctl fails due a wrong dmabuf length, it's
useful to get the invalid and minimum lengths as a debug info.

Before this patch:

vb2-core: __qbuf_dmabuf: invalid dmabuf length for plane 1

After this patch:

vb2-core: __qbuf_dmabuf: invalid dmabuf length 221248 for plane 1, minimum length 410880

Signed-off-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent f223c30f

drivers/media/v4l2-core/videobuf2-core.c

+4 −2
Original line number Diff line number Diff line
@@ -1228,8 +1228,10 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb) 
			planes[plane].length = dbuf->size;



		if (planes[plane].length < vb->planes[plane].min_length) {

			dprintk(1, "invalid dmabuf length for plane %d\n",

				plane);

			dprintk(1, "invalid dmabuf length %u for plane %d, "

				"minimum length %u\n",

				planes[plane].length, plane,

				vb->planes[plane].min_length);

			dma_buf_put(dbuf);

			ret = -EINVAL;

			goto err;