Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13603685 authored by Max Lohrmann's avatar Max Lohrmann Committed by Nicholas Bellinger
Browse files

target: Fix VERIFY_16 handling in sbc_parse_cdb 



As reported by Max, the Windows 2008 R2 chkdsk utility expects
VERIFY_16 to be supported, and does not handle the returned
CHECK_CONDITION properly, resulting in an infinite loop.

The kernel will log huge amounts of this error:

kernel: TARGET_CORE[iSCSI]: Unsupported SCSI Opcode 0x8f, sending
CHECK_CONDITION.

Signed-off-by: default avatarMax Lohrmann <post@wickenrode.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent a04e54f2

drivers/target/target_core_sbc.c

+8 −2
Original line number Diff line number Diff line
@@ -1105,9 +1105,15 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops) 
			return ret;

		break;

	case VERIFY:

	case VERIFY_16:

		size = 0;

		if (cdb[0] == VERIFY) {

			sectors = transport_get_sectors_10(cdb);

			cmd->t_task_lba = transport_lba_32(cdb);

		} else {

			sectors = transport_get_sectors_16(cdb);

			cmd->t_task_lba = transport_lba_64(cdb);

		}

		cmd->execute_cmd = sbc_emulate_noop;

		goto check_lba;

	case REZERO_UNIT: