Commit 1320f768 authored Jan 27, 2018 by Julia Lawall Committed by Thierry Reding Mar 08, 2018

firmware: tegra: adjust tested variable

Check the variable that was most recently initialized.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x, y, f, g, e, m;
statement S1,S2,S3,S4;
@@

x = f(...);
if (\(<+...x...+>\&e\)) S1 else S2
(
x = g(...);
|
m = g(...,&x,...);
|
y = g(...);
*if (e)
 S3 else S4
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

parent 1abb081e

drivers/firmware/tegra/bpmp.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -694,7 +694,7 @@ static int tegra_bpmp_probe(struct platform_device *pdev)
	}		}

	bpmp->rx.virt = gen_pool_dma_alloc(bpmp->rx.pool, 4096, &bpmp->rx.phys);		bpmp->rx.virt = gen_pool_dma_alloc(bpmp->rx.pool, 4096, &bpmp->rx.phys);
	if (!bpmp->rx.pool) {		if (!bpmp->rx.virt) {
	dev_err(&pdev->dev, "failed to allocate from RX pool\n");		dev_err(&pdev->dev, "failed to allocate from RX pool\n");
	err = -ENOMEM;		err = -ENOMEM;
	goto free_tx;		goto free_tx;