Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12de44f5 authored by Fabio Estevam's avatar Fabio Estevam Committed by Shawn Guo
Browse files

ARM: dts: imx: Fix Ethernet PHY reset polarity 



The FEC driver ignores the GPIO polarity from 'phy-reset-gpios' and
considers that the Ethernet PHY is active low, unless the
property 'phy-reset-active-high' is present.

Fix the device tree description by explicitly passing the
'GPIO_ACTIVE_LOW' flag to the 'phy-reset-gpios' property.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 37de44f2

arch/arm/boot/dts/imx25-karo-tx25.dts

+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ 
&fec {

	pinctrl-names = "default";

	pinctrl-0 = <&pinctrl_fec>;

	phy-reset-gpios = <&gpio3 7 0>;

	phy-reset-gpios = <&gpio3 7 GPIO_ACTIVE_LOW>;

	phy-mode = "rmii";

	phy-supply = <&reg_fec_phy>;

	status = "okay";

arch/arm/boot/dts/imx25-pdk.dts

+1 −1
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ 
	pinctrl-names = "default";

	pinctrl-0 = <&pinctrl_fec>;

	phy-supply = <&reg_fec_3v3>;

	phy-reset-gpios = <&gpio4 8 0>;

	phy-reset-gpios = <&gpio4 8 GPIO_ACTIVE_LOW>;

	status = "okay";

};

arch/arm/boot/dts/imx25.dtsi

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
 * http://www.gnu.org/copyleft/gpl.html

 */



#include <dt-bindings/gpio/gpio.h>

#include "imx25-pinfunc.h"



/ {

arch/arm/boot/dts/imx28-cfa10037.dts

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ 
			pinctrl-names = "default";

			pinctrl-0 = <&mac0_pins_a

				&mac0_pins_cfa10037>;

			phy-reset-gpios = <&gpio2 21 0>;

			phy-reset-gpios = <&gpio2 21 GPIO_ACTIVE_LOW>;

			phy-reset-duration = <100>;

			status = "okay";

		};

arch/arm/boot/dts/imx28-cfa10049.dts

+1 −1
Original line number Diff line number Diff line
@@ -327,7 +327,7 @@ 
			pinctrl-names = "default";

			pinctrl-0 = <&mac0_pins_a

				&mac0_pins_cfa10049>;

			phy-reset-gpios = <&gpio2 21 0>;

			phy-reset-gpios = <&gpio2 21 GPIO_ACTIVE_LOW>;

			phy-reset-duration = <100>;

			status = "okay";

		};