Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12669631 authored by Sasha Levin's avatar Sasha Levin Committed by Bjorn Helgaas
Browse files

PCI: Prevent out of bounds access in numa_node override 



63692df1 ("PCI: Allow numa_node override via sysfs") didn't check that
the numa node provided by userspace is valid.  Passing a node number too
high would attempt to access invalid memory and trigger a kernel panic.

Fixes: 63692df1 ("PCI: Allow numa_node override via sysfs")
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
CC: stable@vger.kernel.org	# v3.19+
parent de24c18c

drivers/pci/pci-sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ static ssize_t numa_node_store(struct device *dev, 
	if (ret)

		return ret;



	if (!node_online(node))

	if (node >= MAX_NUMNODES || !node_online(node))

		return -EINVAL;



	add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);