Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 11381286 authored by Shuah Khan (Samsung OSG)'s avatar Shuah Khan (Samsung OSG)
Browse files

selftests: media_tests: return Kselftest Skip code for skipped tests 



When media_tests test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as a
fail by the Kselftest framework. This leads to false negative result
even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
parent f9fedb27

tools/testing/selftests/media_tests/Makefile

+2 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0

#

CFLAGS += -I../ -I../../../../usr/include/

TEST_GEN_PROGS := media_device_test media_device_open video_device_test

all: $(TEST_GEN_PROGS)



include ../lib.mk

tools/testing/selftests/media_tests/media_device_open.c

+4 −4
Original line number Diff line number Diff line
@@ -34,6 +34,8 @@ 
#include <sys/stat.h>

#include <linux/media.h>



#include "../kselftest.h"



int main(int argc, char **argv)

{

	int opt;
@@ -61,10 +63,8 @@ int main(int argc, char **argv) 
		}

	}



	if (getuid() != 0) {

		printf("Please run the test as root - Exiting.\n");

		exit(-1);

	}

	if (getuid() != 0)

		ksft_exit_skip("Please run the test as root - Exiting.\n");



	/* Open Media device and keep it open */

	fd = open(media_device, O_RDWR);

tools/testing/selftests/media_tests/media_device_test.c

+4 −4
Original line number Diff line number Diff line
@@ -39,6 +39,8 @@ 
#include <time.h>

#include <linux/media.h>



#include "../kselftest.h"



int main(int argc, char **argv)

{

	int opt;
@@ -66,10 +68,8 @@ int main(int argc, char **argv) 
		}

	}



	if (getuid() != 0) {

		printf("Please run the test as root - Exiting.\n");

		exit(-1);

	}

	if (getuid() != 0)

		ksft_exit_skip("Please run the test as root - Exiting.\n");



	/* Generate random number of interations */

	srand((unsigned int) time(NULL));